t5612: stop losing return codes of git commands
In a pipe, only the return code of the last command is used. Thus, all other commands will have their return codes masked. Rewrite pipes so that there are no git commands upstream so that their failure is reported. Signed-off-by: Denton Liu <liu.denton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Denton Liu committed
Mar 26, 2020 at 04:27 UTC
3d180973c1bc0723ab4d2225e8df3469cfaa0434
1 file changed
+12
-12
t/t5612-clone-refspec.sh
+12
-12
@@ -71,9 +71,9 @@ test_expect_success 'by default all branches will be kept updated' '
71
(
72
cd dir_all &&
73
git fetch &&
74
- git for-each-ref refs/remotes/origin |
74
+ git for-each-ref refs/remotes/origin >refs &&
75
sed -e "/HEAD$/d" \
76
- -e "s|/remotes/origin/|/heads/|" >../actual
76
+ -e "s|/remotes/origin/|/heads/|" refs >../actual
77
) &&
78
# follow both master and side
79
git for-each-ref refs/heads >expect &&
@@ -104,9 +104,9 @@ test_expect_success '--single-branch while HEAD pointing at master' '
104
(
105
cd dir_master &&
106
git fetch --force &&
107
- git for-each-ref refs/remotes/origin |
107
+ git for-each-ref refs/remotes/origin >refs &&
108
sed -e "/HEAD$/d" \
109
- -e "s|/remotes/origin/|/heads/|" >../actual
109
+ -e "s|/remotes/origin/|/heads/|" refs >../actual
110
) &&
111
# only follow master
112
git for-each-ref refs/heads/master >expect &&
@@ -126,9 +126,9 @@ test_expect_success '--single-branch while HEAD pointing at master and --no-tags
126
(
127
cd dir_master_no_tags &&
128
git fetch &&
129
- git for-each-ref refs/remotes/origin |
129
+ git for-each-ref refs/remotes/origin >refs &&
130
sed -e "/HEAD$/d" \
131
- -e "s|/remotes/origin/|/heads/|" >../actual
131
+ -e "s|/remotes/origin/|/heads/|" refs >../actual
132
) &&
133
# only follow master
134
git for-each-ref refs/heads/master >expect &&
@@ -156,9 +156,9 @@ test_expect_success '--single-branch while HEAD pointing at side' '
156
(
157
cd dir_side &&
158
git fetch &&
159
- git for-each-ref refs/remotes/origin |
159
+ git for-each-ref refs/remotes/origin >refs &&
160
sed -e "/HEAD$/d" \
161
- -e "s|/remotes/origin/|/heads/|" >../actual
161
+ -e "s|/remotes/origin/|/heads/|" refs >../actual
162
) &&
163
# only follow side
164
git for-each-ref refs/heads/side >expect &&
@@ -169,9 +169,9 @@ test_expect_success '--single-branch with explicit --branch side' '
169
(
170
cd dir_side2 &&
171
git fetch &&
172
- git for-each-ref refs/remotes/origin |
172
+ git for-each-ref refs/remotes/origin >refs &&
173
sed -e "/HEAD$/d" \
174
- -e "s|/remotes/origin/|/heads/|" >../actual
174
+ -e "s|/remotes/origin/|/heads/|" refs >../actual
175
) &&
176
# only follow side
177
git for-each-ref refs/heads/side >expect &&
@@ -223,9 +223,9 @@ test_expect_success '--single-branch with detached' '
223
(
224
cd dir_detached &&
225
git fetch &&
226
- git for-each-ref refs/remotes/origin |
226
+ git for-each-ref refs/remotes/origin >refs &&
227
sed -e "/HEAD$/d" \
228
- -e "s|/remotes/origin/|/heads/|" >../actual
228
+ -e "s|/remotes/origin/|/heads/|" refs >../actual
229
) &&
230
# nothing
231
test_must_be_empty actual