http_get_file: style fixes
Besides being ugly, the extra parentheses are idiomatic for suppressing compiler warnings when we are assigning within a conditional. We aren't doing that here, and they just confuse the reader. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Jeff King committed
Sep 28, 2013 at 04:31 UTC
3d1fb769b26dbf278a0ef0cf7427aac86a161bb0
1 file changed
+2
-2
http.c
+2
-2
@@ -941,7 +941,7 @@ static int http_get_file(const char *url, const char *filename, int options)
941
942
strbuf_addf(&tmpfile, "%s.temp", filename);
943
result = fopen(tmpfile.buf, "a");
944
- if (! result) {
944
+ if (!result) {
945
error("Unable to open local file %s", tmpfile.buf);
946
ret = HTTP_ERROR;
947
goto cleanup;
@@ -950,7 +950,7 @@ static int http_get_file(const char *url, const char *filename, int options)
950
ret = http_request_reauth(url, NULL, result, HTTP_REQUEST_FILE, options);
951
fclose(result);
952
953
- if ((ret == HTTP_OK) && move_temp_to_file(tmpfile.buf, filename))
953
+ if (ret == HTTP_OK && move_temp_to_file(tmpfile.buf, filename))
954
ret = HTTP_ERROR;
955
cleanup:
956
strbuf_release(&tmpfile);