Avoid redundant conditions
While `if (i <= 0) ... else if (i > 0) ...` is technically equivalent to `if (i <= 0) ... else ...`, the latter is vastly easier to read because it avoids writing out a condition that is unnecessary. Let's drop such unnecessary conditions. Pointed out by CodeQL. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Johannes Schindelin committed
May 15, 2025 at 13:11 UTC
3d39bcd98ecce0fce77b00fd680bd245b2161ddf
2 files changed
+2
-2
help.c
+1
-1
@@ -214,7 +214,7 @@ void exclude_cmds(struct cmdnames *cmds, struct cmdnames *excludes)
214
else if (cmp == 0) {
215
ei++;
216
free(cmds->names[ci++]);
217
- } else if (cmp > 0)
217
+ } else
218
ei++;
219
}
220
transport-helper.c
+1
-1
@@ -1437,7 +1437,7 @@ static int udt_do_read(struct unidirectional_transfer *t)
1437
transfer_debug("%s EOF (with %i bytes in buffer)",
1438
t->src_name, (int)t->bufuse);
1439
t->state = SSTATE_FLUSHING;
1440
- } else if (bytes > 0) {
1440
+ } else {
1441
t->bufuse += bytes;
1442
transfer_debug("Read %i bytes from %s (buffer now at %i)",
1443
(int)bytes, t->src_name, (int)t->bufuse);