cmd_repack(): remove redundant local variable "nr_packs"
Its value is the same as the number of entries in the "names" string_list, so just use "names.nr" in its place. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Acked-by: Stefan Beller <stefanbeller@googlemail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Michael Haggerty committed
Dec 17, 2013 at 14:43 UTC
3e7b066e2229f45d633164beaeb8815b0973a9b4
1 file changed
+2
-4
builtin/repack.c
+2
-4
@@ -123,7 +123,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix)
123
struct string_list rollback = STRING_LIST_INIT_NODUP;
124
struct string_list existing_packs = STRING_LIST_INIT_DUP;
125
struct strbuf line = STRBUF_INIT;
126
- int nr_packs, ext, ret, failed;
126
+ int ext, ret, failed;
127
FILE *out;
128
129
/* variables to be filled by option parsing */
@@ -233,13 +233,11 @@ int cmd_repack(int argc, const char **argv, const char *prefix)
233
if (ret)
234
return ret;
235
236
- nr_packs = 0;
236
out = xfdopen(cmd.out, "r");
237
while (strbuf_getline(&line, out, '\n') != EOF) {
238
if (line.len != 40)
239
die("repack: Expecting 40 character sha1 lines only from pack-objects.");
240
string_list_append(&names, line.buf);
242
- nr_packs++;
241
}
242
fclose(out);
243
ret = finish_command(&cmd);
@@ -247,7 +245,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix)
245
return ret;
246
argv_array_clear(&cmd_args);
247
250
- if (!nr_packs && !quiet)
248
+ if (!names.nr && !quiet)
249
printf("Nothing new to pack.\n");
250
251
/*