git-p4: remove ticket expiry test
The git-p4 login ticket expiry test causes unreliable test runs. Since the handling of ticket expiry in git-p4 is far from polished anyway, let's remove it for now. A better way to actually run the test is to create a python "fake" version of "p4" which returns whatever expiry results the test requires. Ideally git-p4 would look at the expiry time before starting any long operations, and cleanup gracefully if there is not enough time left. But that's quite hard to do. Signed-off-by: Luke Diamand <luke@diamand.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Luke Diamand committed
Feb 6, 2019 at 15:11 UTC
3f360ded54f57476ab66bb2ae8294d05a4bb1ede
1 file changed
-27
t/t9833-errors.sh
-27
@@ -45,33 +45,6 @@ test_expect_success 'ticket logged out' '
45
)
46
'
47
48
-test_expect_success 'create group with short ticket expiry' '
49
- P4TICKETS="$cli/tickets" &&
50
- echo "newpassword" | p4 login &&
51
- p4_add_user short_expiry_user &&
52
- p4 -u short_expiry_user passwd -P password &&
53
- p4 group -i <<-EOF &&
54
- Group: testgroup
55
- Timeout: 3
56
- Users: short_expiry_user
57
- EOF
58
-
59
- p4 users | grep short_expiry_user
60
-'
61
-
62
-test_expect_success 'git operation with expired ticket' '
63
- P4TICKETS="$cli/tickets" &&
64
- P4USER=short_expiry_user &&
65
- echo "password" | p4 login &&
66
- (
67
- cd "$git" &&
68
- git p4 sync &&
69
- sleep 5 &&
70
- test_must_fail git p4 sync 2>errmsg &&
71
- grep "failure accessing depot" errmsg
72
- )
73
-'
74
-
48
test_expect_success 'kill p4d' '
49
kill_p4d
50
'