clone: do not export and unexport GIT_CONFIG
Earlier, dc87183 (use GIT_CONFIG only in "git config", not other programs, 2008-06-30) made sure that the environment variable is never used outside "git config", but "git clone", after creating a directory for the new repository and until the init_db() function populates its .git/ directory, exported the variable for no good reason. No hook will run from init_db() and more importantly no hook can run until init_db() finishes creation of the new repository, so it cannot be used by any invocation of "git config" by definition. Stop doing the useless export/unexport. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Jan 11, 2013 at 14:43 UTC
3f4f4cc0da03b312fabcd5a509baa8092de39534
1 file changed
-9
builtin/clone.c
-9
@@ -714,8 +714,6 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
714
atexit(remove_junk);
715
sigchain_push_common(remove_junk_on_signal);
716
717
- setenv(CONFIG_ENVIRONMENT, mkpath("%s/config", git_dir), 1);
718
-
717
if (safe_create_leading_directories_const(git_dir) < 0)
718
die(_("could not create leading directories of '%s'"), git_dir);
719
@@ -732,13 +730,6 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
730
init_db(option_template, INIT_DB_QUIET);
731
write_config(&option_config);
732
735
- /*
736
- * At this point, the config exists, so we do not need the
737
- * environment variable. We actually need to unset it, too, to
738
- * re-enable parsing of the global configs.
739
- */
740
- unsetenv(CONFIG_ENVIRONMENT);
741
-
733
git_config(git_default_config, NULL);
734
735
if (option_bare) {