@matheusbsbs / matheus-bagliano / commits / 4041483e5a
Fork 0

[PATCH] fetch.c: Remove call to parse_object() from process()

The call to parse_object() in process() is not actually needed - if the object type is unknown, parse_object() will be called by loop(); if the type is known, the object will be parsed by the appropriate process_*() function. After this change blobs which exist locally are no longer parsed, which gives about 2x CPU usage improvement; the downside is that there will be no warnings for existing corrupted blobs, but detecting such corruption is the job of git-fsck-objects, not the fetch programs. Newly fetched objects are still checked for corruption in http-fetch.c and ssh-fetch.c (local-fetch.c does not seem to do it, but the removed parse_object() call would not be reached for new objects anyway). Signed-off-by: Sergey Vlasov <vsu@altlinux.ru> Signed-off-by: Junio C Hamano <junkio@cox.net>

Sergey Vlasov committed Sep 21, 2005 at 20:34 UTC 4041483e5a3d2010e038ec686ef1638cde659f0b
1 file changed -1
fetch.c
-1
@@ -134,7 +134,6 @@ static int process(struct object *obj)
134 obj->flags |= SEEN;
135
136 if (has_sha1_file(obj->sha1)) {
137 - parse_object(obj->sha1);
137 /* We already have it, so we should scan it now. */
138 obj->flags |= TO_SCAN;
139 } else {