t1300: use test helpers instead of `test` command
Replace `test -f` and `test -h` checks with `test_path_is_file` and `test_path_is_symlink`. Using the test framework helpers provides clearer diagnostics and keeps tests consistent across the suite. Signed-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Pushkar Singh committed
Jan 4, 2026 at 19:47 UTC
404b6772297c77f48de298adf11ab94f080eba72
2 files changed
+6
-6
t/t1300-config.sh
+4
-4
index 358d636379..9850fcd5b5 100755
--- a/t/t1300-config.sh
+++ b/t/t1300-config.sh
@@ -1232,12 +1232,12 @@ test_expect_success SYMLINKS 'symlinked configuration' '
test_when_finished "rm myconfig" &&
ln -s notyet myconfig &&
git config --file=myconfig test.frotz nitfol &&
- test -h myconfig &&
- test -f notyet &&
+ test_path_is_symlink myconfig &&
+ test_path_is_file notyet &&
test "z$(git config --file=notyet test.frotz)" = znitfol &&
git config --file=myconfig test.xyzzy rezrov &&
- test -h myconfig &&
- test -f notyet &&
+ test_path_is_symlink myconfig &&
+ test_path_is_file notyet &&
cat >expect <<-\EOF &&
nitfol
rezrov
t/t2021-checkout-overwrite.sh
+2
-2
index a5c03d5d4a..38c41ae373 100755
--- a/t/t2021-checkout-overwrite.sh
+++ b/t/t2021-checkout-overwrite.sh
@@ -27,7 +27,7 @@ test_expect_success 'checkout commit with dir must not remove untracked a/b' '
git rm --cached a/b &&
git commit -m "un-track the file" &&
test_must_fail git checkout start &&
- test -f a/b
+ test_path_is_file a/b
'
test_expect_success 'create a commit where dir a/b changed to symlink' '
@@ -49,7 +49,7 @@ test_expect_success 'checkout commit with dir must not remove untracked a/b' '
test_expect_success SYMLINKS 'the symlink remained' '
- test -h a/b
+ test_path_is_symlink a/b
'
test_expect_success 'cleanup after previous symlink tests' '