commit-reach: fix memory and flag leaks
The can_all_from_reach_with_flag() method uses 'assign_flag' as a value we can use to mark objects temporarily during our commit walk. The intent is that these flags are removed from all objects before returning. However, this is not the case. The 'from' array could also contain objects that are not commits, and we mark those objects with 'assign_flag'. Add a loop to the 'cleanup' section that removes these markers. Also, we forgot to free() the memory for 'list', so add that to the 'cleanup' section. Signed-off-by: Derrick Stolee <dstolee@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Derrick Stolee committed
Sep 21, 2018 at 08:05 UTC
4067a64672f9db8ca38d5a2682a7cdba7938c18b
1 file changed
+5
commit-reach.c
+5
@@ -626,6 +626,11 @@ cleanup:
626
clear_commit_marks(list[i], RESULT);
627
clear_commit_marks(list[i], assign_flag);
628
}
629
+ free(list);
630
+
631
+ for (i = 0; i < from->nr; i++)
632
+ from->objects[i].item->flags &= ~assign_flag;
633
+
634
return result;
635
}
636