t9600-cvsimport.sh: set HOME before checking for cvsps availability

This actually sounds like a bug in cvsps, which requires an existing home directory when asked for the usage through -h $ HOME=/nonexistent cvsps -h Cannot create the cvsps directory '.cvsps': No such file or directory This made t9600 think that cvsps is not available if HOME did not exist, causing the tests to be skipped $ HOME=/nonexistent sh t9600-cvsimport.sh * skipping cvsimport tests, cvsps not found * passed all 0 test(s) Now t9600 sets HOME to the current working directory before checking for the availability of the cvsps program. This issue has been discovered by Marco Rodrigues, and fixed by Frank Lichtenheld through http://bugs.debian.org/471969 Signed-off-by: Gerrit Pape <pape@smarden.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Frank Lichtenheld committed Mar 26, 2008 at 17:34 UTC 40ae8872a1b8ba117e0365832f6621f968b1221e

1 file changed +6 -6

t/t9600-cvsimport.sh

+6 -6

@@ -3,6 +3,12 @@

3 test_description='git-cvsimport basic tests'

4 . ./test-lib.sh

6 +CVSROOT=$(pwd)/cvsroot

7 +export CVSROOT

8 +# for clean cvsps cache

9 +HOME=$(pwd)

10 +export HOME

11 +

12 if ! type cvs >/dev/null 2>&1

13 then

14 say 'skipping cvsimport tests, cvs not found'

@@ -26,12 +32,6 @@ case "$cvsps_version" in

32 ;;

33 esac

29 -CVSROOT=$(pwd)/cvsroot

30 -export CVSROOT

31 -# for clean cvsps cache

32 -HOME=$(pwd)

33 -export HOME

34 -

35 test_expect_success 'setup cvsroot' 'cvs init'

37 test_expect_success 'setup a cvs module' '