t-reftable-merged: use reftable_ref_record_equal to compare ref records
In the test t_merged_single_record() defined in t-reftable-merged.c, the 'input' and 'expected' ref records are checked for equality by comparing their update indices. It is very much possible for two different ref records to have the same update indices. Use reftable_ref_record_equal() instead for a stronger check. Mentored-by: Patrick Steinhardt <ps@pks.im> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Chandra Pratap committed
Jul 12, 2024 at 11:09 UTC
40c80eab83f3f7eae4be14cccf756c0a89931b59
1 file changed
+1
-1
t/unit-tests/t-reftable-merged.c
+1
-1
@@ -158,7 +158,7 @@ static void t_merged_single_record(void)
158
159
err = reftable_iterator_next_ref(&it, &ref);
160
check(!err);
161
- check_int(ref.update_index, ==, 2);
161
+ check(reftable_ref_record_equal(&r2[0], &ref, GIT_SHA1_RAWSZ));
162
reftable_ref_record_release(&ref);
163
reftable_iterator_destroy(&it);
164
readers_destroy(readers, 3);