replay: small set of cleanups
Perform a small set of cleanups so that the "replay" logic compiles with "-Wsign-compare" and doesn't use `the_repository` anymore. Note that there are still some implicit dependencies on `the_repository`, e.g. because we use `get_commit_output_encoding()`. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Patrick Steinhardt committed
Jan 13, 2026 at 10:54 UTC
410e3780602a5da36a91d7456daf8b1427d80318
1 file changed
+4
-7
replay.c
+4
-7
@@ -1,5 +1,4 @@
1
#define USE_THE_REPOSITORY_VARIABLE
2
-#define DISABLE_SIGN_COMPARE_WARNINGS
2
3
#include "git-compat-util.h"
4
#include "environment.h"
@@ -78,7 +77,7 @@ static struct commit *create_commit(struct repository *repo,
77
obj = parse_object(repo, &ret);
78
79
out:
81
- repo_unuse_commit_buffer(the_repository, based_on, message);
80
+ repo_unuse_commit_buffer(repo, based_on, message);
81
free_commit_extra_headers(extra);
82
free_commit_list(parents);
83
strbuf_release(&msg);
@@ -90,16 +89,14 @@ struct ref_info {
89
struct commit *onto;
90
struct strset positive_refs;
91
struct strset negative_refs;
93
- int positive_refexprs;
94
- int negative_refexprs;
92
+ size_t positive_refexprs;
93
+ size_t negative_refexprs;
94
};
95
96
static void get_ref_information(struct repository *repo,
97
struct rev_cmdline_info *cmd_info,
98
struct ref_info *ref_info)
99
{
101
- int i;
102
-
100
ref_info->onto = NULL;
101
strset_init(&ref_info->positive_refs);
102
strset_init(&ref_info->negative_refs);
@@ -121,7 +118,7 @@ static void get_ref_information(struct repository *repo,
118
* the second because they'd likely just be replaying commits on top
119
* of the same commit and not making any difference.
120
*/
124
- for (i = 0; i < cmd_info->nr; i++) {
121
+ for (size_t i = 0; i < cmd_info->nr; i++) {
122
struct rev_cmdline_entry *e = cmd_info->rev + i;
123
struct object_id oid;
124
const char *refexpr = e->name;