Meta/CannedResponses: do not iterate too quickly
Junio C Hamano committed
Jun 5, 2025 at 16:04 UTC
41ebd169815173690fa91d5e312fcfc6074f36eb
1 file changed
+17
-1
CannedResponses
+17
-1
@@ -12,7 +12,7 @@ The usual way to compose a log message of this project is to
12
- Propose a solution (optional---often, problem description
13
trivially leads to an obvious solution in reader's minds).
14
15
- - Give commands to the codebase to "become like so".
15
+ - Give commands to somebody editing the codebase to "make it so".
16
17
in this order.
18
@@ -107,3 +107,19 @@ entirely and replacing it with the newer one. In such a case, we do
107
revert the earlier and replace it with the newer, in 'next'.
108
109
----------------------------------------------------------------
110
+[do not iterate too quickly]
111
+
112
+After sending your patches out, it would be nice to give potential
113
+reviewers at least 24 hours to ensure people anywhere on the globe
114
+have a chance to comment, and a chance for you to respond to them,
115
+before sending your next iteration.
116
+
117
+When responding to a review comment that causes you to drastically
118
+change the course of the series, it is nice to give potential
119
+reviewers at least 24 hours to ensure they have a chance to voice
120
+their opinions, before sending an updated series based on that
121
+comment, because suggested changes in such a comment may be
122
+controversial and deserve discussion. After seeing you spend some
123
+time already to adjust to one opinion on such a discussion, others may
124
+feel discouraged to make you redo your series again even whey they
125
+think the suggested changes are not taking us in the right direction.