t: avoid git config syntax from newer releases
In a recent security release, 05e9cd64ee (config: quote values containing CR character, 2025-05-19) added calls to `git config get`, `git config set`, and `git config unset` which are not present on the maint-2.43 branch. These subcommands were added in the following commits, released in git-2.46.0: 4e51389000 (builtin/config: introduce "get" subcommand, 2024-05-06), 00bbdde141 (builtin/config: introduce "set" subcommand, 2024-05-06), 95ea69c67b (builtin/config: introduce "unset" subcommand, 2024-05-06) Revert to the previous `git config` syntax for older maintenance branches. Signed-off-by: Todd Zullinger <tmz@pobox.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Todd Zullinger committed
Jul 8, 2025 at 17:05 UTC
428c9241c6918f52ac22fb8e83ce7c736a2f5e00
2 files changed
+4
-4
t/t1300-config.sh
+2
-2
@@ -2595,8 +2595,8 @@ test_expect_success 'writing value with trailing CR not stripped on read' '
2595
2596
printf "bar\r\n" >expect &&
2597
git init cr-test &&
2598
- git -C cr-test config set core.foo $(printf "bar\r") &&
2599
- git -C cr-test config get core.foo >actual &&
2598
+ git -C cr-test config core.foo $(printf "bar\r") &&
2599
+ git -C cr-test config --get core.foo >actual &&
2600
2601
test_cmp expect actual
2602
'
t/t7450-bad-git-dotfiles.sh
+2
-2
@@ -362,10 +362,10 @@ test_expect_success SYMLINKS,!WINDOWS,!MINGW 'submodule must not checkout into d
362
git -C repo mv sub $(printf "sub\r") &&
363
364
# Ensure config values containing CR are wrapped in quotes.
365
- git config unset -f repo/.gitmodules submodule.sub.path &&
365
+ git config --unset -f repo/.gitmodules submodule.sub.path &&
366
printf "\tpath = \"sub\r\"\n" >>repo/.gitmodules &&
367
368
- git config unset -f repo/.git/modules/sub/config core.worktree &&
368
+ git config --unset -f repo/.git/modules/sub/config core.worktree &&
369
{
370
printf "[core]\n" &&
371
printf "\tworktree = \"../../../sub\r\"\n"