t7415: don't bother creating commit for symlink test
Early versions of the fsck .gitmodules detection code actually required a tree to be at the root of a commit for it to be checked for .gitmodules. What we ended up with in 159e7b080b (fsck: detect gitmodules files, 2018-05-02), though, finds a .gitmodules file in _any_ tree (see that commit for more discussion). As a result, there's no need to create a commit in our tests. Let's drop it in the name of simplicity. And since that was the only thing referencing $tree, we can pull our tree creation out of a command substitution. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jun 11, 2018 at 04:35 UTC
431acd2de89ad5ec0a3e6ae6141e699c4a824ae1
1 file changed
+4
-7
t/t7415-submodule-names.sh
+4
-7
@@ -135,13 +135,10 @@ test_expect_success 'fsck detects symlinked .gitmodules file' '
135
tricky="[foo]bar=true" &&
136
content=$(git hash-object -w ../.gitmodules) &&
137
target=$(printf "$tricky" | git hash-object -w --stdin) &&
138
- tree=$(
139
- {
140
- printf "100644 blob $content\t$tricky\n" &&
141
- printf "120000 blob $target\t.gitmodules\n"
142
- } | git mktree
143
- ) &&
144
- commit=$(git commit-tree $tree) &&
138
+ {
139
+ printf "100644 blob $content\t$tricky\n" &&
140
+ printf "120000 blob $target\t.gitmodules\n"
141
+ } | git mktree &&
142
143
# Check not only that we fail, but that it is due to the
144
# symlink detector; this grep string comes from the config