t7005-editor: get rid of the SPACES_IN_FILENAMES prereq
The last two tests 'editor with a space' and 'core.editor with a space' in 't7005-editor.sh' need the SPACES_IN_FILENAMES prereq to ensure that they are only run on filesystems that allow, well, spaces in filenames. However, we have been putting a space in the name of the trash directory for just over a decade now, so we wouldn't be able to run any of our tests on such a filesystem in the first place. This prereq is therefore unnecessary, remove it. Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
SZEDER Gábor committed
May 14, 2018 at 12:28 UTC
4362da078e0b507fbb322ac3b33476a863f32493
1 file changed
+3
-9
t/t7005-editor.sh
+3
-9
@@ -111,14 +111,8 @@ do
111
'
112
done
113
114
-if echo 'echo space > "$1"' > "e space.sh"
115
-then
116
- # FS supports spaces in filenames
117
- test_set_prereq SPACES_IN_FILENAMES
118
-fi
119
-
120
-test_expect_success SPACES_IN_FILENAMES 'editor with a space' '
121
-
114
+test_expect_success 'editor with a space' '
115
+ echo "echo space >\$1" >"e space.sh" &&
116
chmod a+x "e space.sh" &&
117
GIT_EDITOR="./e\ space.sh" git commit --amend &&
118
test space = "$(git show -s --pretty=format:%s)"
@@ -126,7 +120,7 @@ test_expect_success SPACES_IN_FILENAMES 'editor with a space' '
120
'
121
122
unset GIT_EDITOR
129
-test_expect_success SPACES_IN_FILENAMES 'core.editor with a space' '
123
+test_expect_success 'core.editor with a space' '
124
125
git config core.editor \"./e\ space.sh\" &&
126
git commit --amend &&