@matheusbsbs / matheus-bagliano / commits / 436a42215e

max_tree_depth: lower it for clangarm64 on Windows

Just as in b64d78ad02ca (max_tree_depth: lower it for MSVC to avoid stack overflows, 2023-11-01), I encountered the same problem with the clang builds on Windows/ARM64. The symptom is an exit code 127 when t6700 tries to verify that `git archive big` fails. This exit code is reserved on Unix/Linux to mean "command not found". Unfortunately in this case, it is the fall-back chosen by Cygwin's `pinfo::status_exit()` method when encountering the NSTATUS `STATUS_STACK_OVERFLOW`, see https://github.com/cygwin/cygwin/blob/cygwin-3.6.1/winsup/cygwin/pinfo.cc#L171 I verified manually that the stack overflow always happens somewhere around tree depth 1403, therefore 1280 should be a safe bound in these instances. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Schindelin committed Apr 23, 2025 at 08:01 UTC 436a42215e51fa2f8b74d128472d7d9bfe2595e1

1 file changed +10

environment.c

+10

@@ -82,6 +82,16 @@ int max_allowed_tree_depth =

82 * the stack overflow can occur.

83 */

84 512;

85 +#elif defined(GIT_WINDOWS_NATIVE) && defined(__clang__) && defined(__aarch64__)

86 + /*

87 + * Similar to Visual C, it seems that on Windows/ARM64 the clang-based

88 + * builds have a smaller stack space available. When running out of

89 + * that stack space, a `STATUS_STACK_OVERFLOW` is produced. When the

90 + * Git command was run from an MSYS2 Bash, this unfortunately results

91 + * in an exit code 127. Let's prevent that by lowering the maximal

92 + * tree depth; This value seems to be low enough.

93 + */

94 + 1280;

95 #else

96 2048;

97 #endif