send-email: get rid of indirect object syntax
Change indirect object syntax such as "new X ARGS" to "X->new(ARGS)". This allows perl to see what "new" is at compile-time without having loaded Term::ReadLine. This doesn't matter now, but will in a subsequent commit when we start lazily loading it. Let's do the same for the adjacent "FakeTerm" package for consistency, even though we're not going to conditionally load it. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
May 28, 2021 at 11:23 UTC
447ed29c0d414547914c23e92f8bb13fcf748f9b
1 file changed
+3
-3
git-send-email.perl
+3
-3
@@ -194,11 +194,11 @@ my $repo = eval { Git->repository() };
194
my @repo = $repo ? ($repo) : ();
195
my $term = eval {
196
$ENV{"GIT_SEND_EMAIL_NOTTY"}
197
- ? new Term::ReadLine 'git-send-email', \*STDIN, \*STDOUT
198
- : new Term::ReadLine 'git-send-email';
197
+ ? Term::ReadLine->new('git-send-email', \*STDIN, \*STDOUT)
198
+ : Term::ReadLine->new('git-send-email');
199
};
200
if ($@) {
201
- $term = new FakeTerm "$@: going non-interactive";
201
+ $term = FakeTerm->new("$@: going non-interactive");
202
}
203
204
# Behavior modification variables