@matheusbsbs / matheus-bagliano / commits / 449f5c751c

t4211: retire soon-to-be unimplementable tests

58960978 and 99780b0a added tests which demonstrated bugs (crashes) in range-set and line-log when handed empty ranges specified via "log -LX:file" where X is one greater than the last line of the file. After these tests were added, it was realized that the ability to specify an empty range is a loophole due to a bug in -L bounds checking. That bug is slated to be fixed in a subsequent patch. Unfortunately, the closure of this loophole makes it impossible to continue checking range-set and line-log behavior with regard to empty ranges since there is no other way to specify empty ranges via the command-line. APIs of both facilities are private (file static) so there likewise is no way to test their behaviors programmatically. Consequently, retire these two tests. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Eric Sunshine committed Jul 31, 2013 at 04:15 UTC 449f5c751c22a12de48c273395540a42460795eb

1 file changed -13

t/t4211-line-log.sh

-13

@@ -94,17 +94,4 @@ test_expect_success '-L ,Y (Y == nlines + 2)' '

94 test_must_fail git log -L ,$n:b.c

95 '

97 -# There is a separate bug when an empty -L range is the first -L encountered,

98 -# thus to demonstrate this particular bug, the empty -L range must follow a

99 -# non-empty -L range.

100 -test_expect_success '-L {empty-range} (any -L)' '

101 - n=$(expr $(wc -l <b.c) + 1) &&

102 - git log -L1,1:b.c -L$n:b.c

103 -'

104 -

105 -test_expect_success '-L {empty-range} (first -L)' '

106 - n=$(expr $(wc -l <b.c) + 1) &&

107 - git log -L$n:b.c

108 -'

109 -

97 test_done