show-branch: note about its object flags usage
This is another candidate for commit-slab. Keep Junio's observation in code so we can search it later on when somebody wants to improve the code. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Nguyễn Thái Ngọc Duy committed
May 19, 2018 at 07:28 UTC
44cecbf8a02921a60eb6f7461f6877329edc8a0d
2 files changed
+6
builtin/show-branch.c
+5
@@ -22,6 +22,11 @@ static int showbranch_use_color = -1;
22
23
static struct argv_array default_args = ARGV_ARRAY_INIT;
24
25
+/*
26
+ * TODO: convert this use of commit->object.flags to commit-slab
27
+ * instead to store a pointer to ref name directly. Then use the same
28
+ * UNINTERESTING definition from revision.h here.
29
+ */
30
#define UNINTERESTING 01
31
32
#define REV_SHIFT 2
object.h
+1
@@ -43,6 +43,7 @@ struct object_array {
43
* builtin/index-pack.c: 2021
44
* builtin/pack-objects.c: 20
45
* builtin/reflog.c: 10--12
46
+ * builtin/show-branch.c: 0-------------------------------------------26
47
* builtin/unpack-objects.c: 2021
48
*/
49
#define FLAG_BITS 27