patch-id: use oid_to_hex() to print multiple object IDs

flush_current_id() prints the hexadecimal representation of two object IDs. When the code was added in f97672225b (Add "git-patch-id" program to generate patch ID's., 2005-06-23), sha1_to_hex() had only a single internal static buffer, so the result of one invocation had to be stored in a local buffer. Since dcb3450fd8 (sha1_to_hex() usage cleanup, 2006-05-03) it rotates through four buffers, which allows to print up to four object IDs at the same time. 1a876a69af6 (patch-id: convert to use struct object_id, 2015-03-13) replaced sha1_to_hex() with oid_to_hex(), which has the same feature. Use it to simplify the code. Signed-off-by: René Scharfe <l.s.r@web.de> Acked-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

René Scharfe committed Dec 7, 2019 at 20:16 UTC 4507ecc7710e172ed36421eaa4efe743785ccb4b

1 file changed +2 -7

builtin/patch-id.c

+2 -7

@@ -5,13 +5,8 @@

6 static void flush_current_id(int patchlen, struct object_id *id, struct object_id *result)

7 {

8 - char name[GIT_MAX_HEXSZ + 1];

9 -

10 - if (!patchlen)

11 - return;

12 -

13 - memcpy(name, oid_to_hex(id), the_hash_algo->hexsz + 1);

14 - printf("%s %s\n", oid_to_hex(result), name);

8 + if (patchlen)

9 + printf("%s %s\n", oid_to_hex(result), oid_to_hex(id));

10 }

12 static int remove_space(char *line)