ident: make user_ident_explicitly_given static
In v1.5.6-rc0~56^2 (2008-05-04) "user_ident_explicitly_given" was introduced as a global for communication between config, ident, and builtin-commit. In v1.7.0-rc0~72^2 (2010-01-07) readers switched to using the common wrapper user_ident_sufficiently_given(). After v1.7.11-rc1~15^2~18 (2012-05-21), the var is only written in ident.c. Now we can make it static, which will enable further refactoring without worrying about upsetting other code. Signed-off-by: Jeff King <peff@peff.net> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Nov 14, 2012 at 16:34 UTC
452802309c422ce71f1c038357ee0775af5fb3eb
2 files changed
+5
-5
cache.h
-4
@@ -1149,10 +1149,6 @@ struct config_include_data {
1149
#define CONFIG_INCLUDE_INIT { 0 }
1150
extern int git_config_include(const char *name, const char *value, void *data);
1151
1152
-#define IDENT_NAME_GIVEN 01
1153
-#define IDENT_MAIL_GIVEN 02
1154
-#define IDENT_ALL_GIVEN (IDENT_NAME_GIVEN|IDENT_MAIL_GIVEN)
1155
-extern int user_ident_explicitly_given;
1152
extern int user_ident_sufficiently_given(void);
1153
1154
extern const char *git_commit_encoding;
ident.c
+5
-1
@@ -10,7 +10,11 @@
10
static struct strbuf git_default_name = STRBUF_INIT;
11
static struct strbuf git_default_email = STRBUF_INIT;
12
static char git_default_date[50];
13
-int user_ident_explicitly_given;
13
+
14
+#define IDENT_NAME_GIVEN 01
15
+#define IDENT_MAIL_GIVEN 02
16
+#define IDENT_ALL_GIVEN (IDENT_NAME_GIVEN|IDENT_MAIL_GIVEN)
17
+static int user_ident_explicitly_given;
18
19
#ifdef NO_GECOS_IN_PWENT
20
#define get_gecos(ignored) "&"