reftable/stack: unconditionally reload stack after commit
After we have committed an addition to the reftable stack we call `reftable_stack_reload()` to reload the stack and thus reflect the changes that were just added. This function will only conditionally reload the stack in case `stack_uptodate()` tells us that the stack needs reloading. This check is wasteful though because we already know that the stack needs reloading. Call `reftable_stack_reload_maybe_reuse()` instead, which will unconditionally reload the stack. This is merely a conceptual fix, the code in question was not found to cause any problems in practice. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Patrick Steinhardt committed
Jan 18, 2024 at 14:41 UTC
456333eb4d00a2bc8a71134bedfe5d3bc13a1932
1 file changed
+1
-1
reftable/stack.c
+1
-1
@@ -585,7 +585,7 @@ int reftable_addition_commit(struct reftable_addition *add)
585
add->new_tables = NULL;
586
add->new_tables_len = 0;
587
588
- err = reftable_stack_reload(add->stack);
588
+ err = reftable_stack_reload_maybe_reuse(add->stack, 1);
589
if (err)
590
goto done;
591