commit-graph.c: make 'commit-graph-chain's read-only
In a previous commit, we made incremental graph layers read-only by using 'git_mkstemp_mode' with permissions '0444'. There is no reason that 'commit-graph-chain's should be modifiable by the user, since they are generated at a temporary location and then atomically renamed into place. To ensure that these files are read-only, too, use 'hold_lock_file_for_update_mode' with the same read-only permission bits, and let the umask and 'adjust_shared_perm' take care of the rest. Signed-off-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Taylor Blau committed
Apr 29, 2020 at 11:36 UTC
45a4365cb610adce1c37c099da7d18619725ce4f
2 files changed
+4
-1
commit-graph.c
+2
-1
@@ -1378,7 +1378,8 @@ static int write_commit_graph_file(struct write_commit_graph_context *ctx)
1378
if (ctx->split) {
1379
char *lock_name = get_chain_filename(ctx->odb);
1380
1381
- hold_lock_file_for_update(&lk, lock_name, LOCK_DIE_ON_ERROR);
1381
+ hold_lock_file_for_update_mode(&lk, lock_name,
1382
+ LOCK_DIE_ON_ERROR, 0444);
1383
1384
fd = git_mkstemp_mode(ctx->graph_name, 0444);
1385
if (fd < 0) {
t/t5324-split-commit-graph.sh
+2
@@ -366,6 +366,8 @@ do
366
test_line_count = 1 graph-files &&
367
echo "$modebits" >expect &&
368
test_modebits $graphdir/graph-*.graph >actual &&
369
+ test_cmp expect actual &&
370
+ test_modebits $graphdir/commit-graph-chain >actual &&
371
test_cmp expect actual
372
'
373
done <<\EOF