stream_blob_to_fd: detect errors reading from stream
We call read_istream, but never check its return value for errors. This can lead to us looping infinitely, as we just keep trying to write "-1" bytes (and we do not notice the error, as we simply check that write_in_full reports the same number of bytes we fed it, which of course is also -1). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Mar 25, 2013 at 16:16 UTC
45d4bdae5906cfe6b7cb1ba1cec82fd80381e07e
1 file changed
+2
streaming.c
+2
@@ -514,6 +514,8 @@ int stream_blob_to_fd(int fd, unsigned const char *sha1, struct stream_filter *f
514
ssize_t wrote, holeto;
515
ssize_t readlen = read_istream(st, buf, sizeof(buf));
516
517
+ if (readlen < 0)
518
+ goto close_and_exit;
519
if (!readlen)
520
break;
521
if (can_seek && sizeof(buf) == readlen) {