tag: remove a TODO item from the test suite
Change the test for "git tag -l" to not have an associated TODO comment saying that it should return non-zero if there's no tags. This was added in commit ef5a6fb597 ("Add test-script for git-tag", 2007-06-28) when the tests for "tag" were initially added, but at this point changing this would be inconsistent with how "git tag" is a synonym for "git tag -l", and would needlessly break external code that relies on this porcelain command. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Mar 23, 2017 at 13:05 UTC
4612edc639e8c7c15420960a92efa609e92ab9a7
1 file changed
-2
t/t7004-tag.sh
-2
@@ -16,7 +16,6 @@ tag_exists () {
16
git show-ref --quiet --verify refs/tags/"$1"
17
}
18
19
-# todo: git tag -l now returns always zero, when fixed, change this test
19
test_expect_success 'listing all tags in an empty tree should succeed' '
20
git tag -l &&
21
git tag
@@ -136,7 +135,6 @@ test_expect_success \
135
'listing a tag using a matching pattern should output that tag' \
136
'test $(git tag -l mytag) = mytag'
137
139
-# todo: git tag -l now returns always zero, when fixed, change this test
138
test_expect_success \
139
'listing tags using a non-matching pattern should suceed' \
140
'git tag -l xxx'