@matheusbsbs / matheus-bagliano / commits / 464c9ffee4
Fork 0

git-gui: Don't show content of untracked binary files.

A binary file can be very large, and showing the complete content of one is horribly ugly and confusing. So we now use the same rule that core Git uses; if there is a NUL byte (\0) within the first 8000 bytes of the file we assume it is binary and refuse to show the content. Given that we have loaded the entire content of the file into memory we probably could just afford to search the whole thing, but we also probably should not load multi-megabyte binary files either. Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

Shawn O. Pearce committed Jan 23, 2007 at 02:08 UTC 464c9ffee45520c8be3ec656f926224501bcf977
1 file changed +3
git-gui.sh
+3
@@ -637,6 +637,9 @@ proc show_diff {path w {lno {}}} {
637 error_popup "Error loading file:\n\n$err"
638 return
639 }
640 + if {[string first "\0" [string range $content 0 8000]] != -1} {
641 + set content {* Binary file (not showing content).}
642 + }
643 $ui_diff conf -state normal
644 $ui_diff insert end $content
645 $ui_diff conf -state disabled