packfile: remove GIT_DEBUG_LOOKUP log statements

In commit 628522ec1439 ("sha1-lookup: more memory efficient search in sorted list of SHA-1", 2008-04-09), a different algorithm for searching a sorted list was introduced, together with a set of log statements guarded by GIT_DEBUG_LOOKUP that are invoked both when using that algorithm and when using the existing binary search. Those log statements was meant for experiments and debugging, but with the removal of the aforementioned different algorithm in commit f1068efefe6d ("sha1_file: drop experimental GIT_USE_LOOKUP search", 2017-08-09), those log statements are probably no longer necessary. Remove those statements. Signed-off-by: Jonathan Tan <jonathantanmy@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jonathan Tan committed Feb 13, 2018 at 10:39 UTC 4669e7d68ec8fb6ff3572a1193ae75ae2094b8e6
1 file changed -11
packfile.c
-11
@@ -1713,10 +1713,6 @@ off_t find_pack_entry_one(const unsigned char *sha1,
1713 const uint32_t *level1_ofs = p->index_data;
1714 const unsigned char *index = p->index_data;
1715 unsigned hi, lo, stride;
1716 - static int debug_lookup = -1;
1717 -
1718 - if (debug_lookup < 0)
1719 - debug_lookup = !!getenv("GIT_DEBUG_LOOKUP");
1716
1717 if (!index) {
1718 if (open_pack_index(p))
@@ -1738,17 +1734,10 @@ off_t find_pack_entry_one(const unsigned char *sha1,
1734 index += 4;
1735 }
1736
1741 - if (debug_lookup)
1742 - printf("%02x%02x%02x... lo %u hi %u nr %"PRIu32"\n",
1743 - sha1[0], sha1[1], sha1[2], lo, hi, p->num_objects);
1744 -
1737 while (lo < hi) {
1738 unsigned mi = lo + (hi - lo) / 2;
1739 int cmp = hashcmp(index + mi * stride, sha1);
1740
1749 - if (debug_lookup)
1750 - printf("lo %u hi %u rg %u mi %u\n",
1751 - lo, hi, hi - lo, mi);
1741 if (!cmp)
1742 return nth_packed_object_offset(p, mi);
1743 if (cmp > 0)