git-gui: sort entries in optimized tclIndex
auto_mkindex expands wildcards in directory order, which depends on the underlying filesystem. To improve build reproducibility, sort the list of *.tcl files in the Makefile. The unoptimized loading case was previously fixed in gitgui-0.21.0~14 (git-gui: sort entries in tclIndex, 2015-01-26). Signed-off-by: Anders Kaseorg <andersk@mit.edu> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Anders Kaseorg committed
Nov 16, 2016 at 16:37 UTC
474642b4a47c74a1f277955d7387d1886546fa01
1 file changed
+1
-1
Makefile
+1
-1
@@ -252,7 +252,7 @@ $(ALL_MSGFILES): %.msg : %.po
252
lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
253
$(QUIET_INDEX)if echo \
254
$(foreach p,$(PRELOAD_FILES),source $p\;) \
255
- auto_mkindex lib '*.tcl' \
255
+ auto_mkindex lib $(patsubst lib/%,%,$(sort $(ALL_LIBFILES))) \
256
| $(TCL_PATH) $(QUIET_2DEVNULL); then : ok; \
257
else \
258
echo >&2 " * $(TCL_PATH) failed; using unoptimized loading"; \