pack-bitmap: drop unused parameters from select_pseudo_merges()
We take the array of indexed_commits (and its length), but there's no need. The selection is based on ref reachability, not the linearized set of commits we're packing. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Aug 17, 2024 at 03:29 UTC
47564945046f8cda634ee72c5b3838c1b0aa4582
3 files changed
+3
-5
pack-bitmap-write.c
+1
-1
@@ -737,7 +737,7 @@ void bitmap_writer_select_commits(struct bitmap_writer *writer,
737
738
stop_progress(&writer->progress);
739
740
- select_pseudo_merges(writer, indexed_commits, indexed_commits_nr);
740
+ select_pseudo_merges(writer);
741
}
742
743
pseudo-merge.c
+1
-2
@@ -425,8 +425,7 @@ static void sort_pseudo_merge_matches(struct pseudo_merge_matches *matches)
425
QSORT(matches->unstable, matches->unstable_nr, commit_date_cmp);
426
}
427
428
-void select_pseudo_merges(struct bitmap_writer *writer,
429
- struct commit **commits, size_t commits_nr)
428
+void select_pseudo_merges(struct bitmap_writer *writer)
429
{
430
struct progress *progress = NULL;
431
uint32_t i;
pseudo-merge.h
+1
-2
@@ -95,8 +95,7 @@ struct pseudo_merge_commit_idx {
95
*
96
* Optionally shows a progress meter.
97
*/
98
-void select_pseudo_merges(struct bitmap_writer *writer,
99
- struct commit **commits, size_t commits_nr);
98
+void select_pseudo_merges(struct bitmap_writer *writer);
99
100
/*
101
* Represents a serialized view of a file containing pseudo-merge(s)