gitweb: make repeated calls to git_get_project_owner() bearable
If repeated calls to git_get_project_owner() are made, we would have read the same file over and over again. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Jul 3, 2007 at 22:10 UTC
478524508e2f49af8cc76f2d7294a3b33facf121
1 file changed
+20
-8
gitweb/gitweb.perl
+20
-8
@@ -1465,12 +1465,12 @@ sub git_get_projects_list {
1465
return @list;
1466
}
1467
1468
-sub git_get_project_owner {
1469
- my $project = shift;
1470
- my $owner;
1468
+our $gitweb_project_owner = undef;
1469
+sub git_get_project_list_from_file {
1470
1472
- return undef unless $project;
1471
+ return if (defined $gitweb_project_owner);
1472
1473
+ $gitweb_project_owner = {};
1474
# read from file (url-encoded):
1475
# 'git%2Fgit.git Linus+Torvalds'
1476
# 'libs%2Fklibc%2Fklibc.git H.+Peter+Anvin'
@@ -1482,13 +1482,25 @@ sub git_get_project_owner {
1482
my ($pr, $ow) = split ' ', $line;
1483
$pr = unescape($pr);
1484
$ow = unescape($ow);
1485
- if ($pr eq $project) {
1486
- $owner = to_utf8($ow);
1487
- last;
1488
- }
1485
+ $gitweb_project_owner->{$pr} = to_utf8($ow);
1486
}
1487
close $fd;
1488
}
1489
+}
1490
+
1491
+sub git_get_project_owner {
1492
+ my $project = shift;
1493
+ my $owner;
1494
+
1495
+ return undef unless $project;
1496
+
1497
+ if (!defined $gitweb_project_owner) {
1498
+ git_get_project_list_from_file();
1499
+ }
1500
+
1501
+ if (exists $gitweb_project_owner->{$project}) {
1502
+ $owner = $gitweb_project_owner->{$project};
1503
+ }
1504
if (!defined $owner) {
1505
$owner = get_file_owner("$projectroot/$project");
1506
}