@matheusbsbs / matheus-bagliano / commits / 47a0b75e01
Fork 0

git-svn: avoid a huge memory spike with high-numbered revisions

Passing very large strings as arguments is bad for memory usage as it never seems to get freed in Perl. The .rev_db format is already not optimized for projects with sparse history. Signed-off-by: Eric Wong <normalperson@yhbt.net>

Eric Wong committed Jan 31, 2007 at 05:13 UTC 47a0b75e01876b6e138d78c9504eebedd45c1283
1 file changed +3 -2
git-svn.perl
+3 -2
@@ -1345,8 +1345,9 @@ sub rev_db_set {
1345 seek $fh, 0, 2 or croak $!;
1346 my $pos = tell $fh;
1347 if ($pos < $offset) {
1348 - print $fh (('0' x 40),"\n") x (($offset - $pos) / 41)
1349 - or croak $!;
1348 + for (1 .. (($offset - $pos) / 41)) {
1349 + print $fh (('0' x 40),"\n") or croak $!;
1350 + }
1351 }
1352 seek $fh, $offset, 0 or croak $!;
1353 print $fh $commit,"\n" or croak $!;