rebase -i: do not "echo" random user-supplied strings

In some places we "echo" a string that comes from a commit log message, which may have a backslash sequence that is interpreted by the command (POSIX.1 allows this), most notably "dash"'s built-in 'echo'. A commit message which contains the string '\n' (or ends with the string '\c') may result in a garbage line in the todo list of an interactive rebase which causes the rebase to fail. To reproduce the behavior (with dash as /bin/sh): mkdir test && cd test && git init echo 1 >foo && git add foo git commit -m"this commit message ends with '\n'" echo 2 >foo && git commit -a --fixup HEAD git rebase -i --autosquash --root Now the editor opens with garbage in line 3 which has to be removed or the rebase fails. Signed-off-by: Uwe Storbeck <uwe@ibr.ch> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Uwe Storbeck committed Mar 15, 2014 at 00:56 UTC 47be06602656ee9cac860f675d2c8d1f0deabdbe
1 file changed +1 -1
git-rebase--interactive.sh
+1 -1
@@ -739,7 +739,7 @@ rearrange_squash () {
739 ;;
740 esac
741 done
742 - echo "$sha1 $action $prefix $rest"
742 + printf '%s %s %s %s\n' "$sha1" "$action" "$prefix" "$rest"
743 # if it's a single word, try to resolve to a full sha1 and
744 # emit a second copy. This allows us to match on both message
745 # and on sha1 prefix