MinGW: truncate exit()'s argument to lowest 8 bits
For some reason, MinGW's bash cannot reliably detect failure of the child process if a negative value is passed to exit(). This fixes it by truncating the exit code in all calls of exit(). This issue was worked around in run_builtin() of git.c (2488df84 builtin run_command: do not exit with -1, 2007-11-15). This workaround is no longer necessary and is reverted. Suggested-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Johannes Sixt committed
Jul 5, 2009 at 20:57 UTC
47e3de0e7968a4176e2c54a36b214d3e7b24ad15
2 files changed
+3
-1
compat/mingw.h
+2
@@ -92,6 +92,8 @@ static inline int fcntl(int fd, int cmd, long arg)
92
errno = EINVAL;
93
return -1;
94
}
95
+/* bash cannot reliably detect negative return codes as failure */
96
+#define exit(code) exit((code) & 0xff)
97
98
/*
99
* simple adaptors
git.c
+1
-1
@@ -245,7 +245,7 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
245
246
status = p->fn(argc, argv, prefix);
247
if (status)
248
- return status & 0xff;
248
+ return status;
249
250
/* Somebody closed stdout? */
251
if (fstat(fileno(stdout), &st))