test-lib: simplify GIT_SKIP_TESTS loop
04ece59 (GIT_SKIP_TESTS: allow users to omit tests that are known to break, 2006-12-28) introduced GIT_SKIP_TESTS, and since then we have had two nested loops iterating over GIT_SKIP_TESTS with the same loop variable. Reduce this to one loop. Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Michael J Gruber committed
Jul 12, 2010 at 12:32 UTC
47e67d479b305bbec996b2422e2776fb7c39be27
1 file changed
+3
-10
t/test-lib.sh
+3
-10
@@ -385,6 +385,7 @@ test_skip () {
385
case $this_test.$test_count in
386
$skp)
387
to_skip=t
388
+ break
389
esac
390
done
391
if test -z "$to_skip" && test -n "$prereq" &&
@@ -829,16 +830,8 @@ this_test=${0##*/}
830
this_test=${this_test%%-*}
831
for skp in $GIT_SKIP_TESTS
832
do
832
- to_skip=
833
- for skp in $GIT_SKIP_TESTS
834
- do
835
- case "$this_test" in
836
- $skp)
837
- to_skip=t
838
- esac
839
- done
840
- case "$to_skip" in
841
- t)
833
+ case "$this_test" in
834
+ $skp)
835
say_color skip >&3 "skipping test $this_test altogether"
836
say_color skip "skip all tests in $this_test"
837
test_done