@matheusbsbs / matheus-bagliano / commits / 491e359c94
Fork 0

t9300: remove unnecessary use of /dev/stdin

We really shouldn't be using these funny /dev/* files that did not exist in V7 UNIX in our tests when we do not have to. Output from $ git grep -n -e /dev/ --and --not -e /dev/null t/ tells us that, aside from use of /dev/urandom in apache.conf used in http tests, "dd if=/dev/stdin" added recently to t/t9300-fast-import.sh are the only offenders, and "dd" reads from the standard input by default, so removing them should be straightforward. Reported-by: Thomas Rast <trast@student.ethz.ch> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Junio C Hamano committed Dec 3, 2010 at 12:28 UTC 491e359c949ef7b7ed3fd24ba59f1b7e4cc17e87
1 file changed +3 -3
t/t9300-fast-import.sh
+3 -3
@@ -1794,7 +1794,7 @@ test_expect_success PIPE 'R: copy using cat-file' '
1794
1795 read blob_id type size <&3 &&
1796 echo "$blob_id $type $size" >response &&
1797 - dd if=/dev/stdin of=blob bs=$size count=1 <&3 &&
1797 + dd of=blob bs=$size count=1 <&3 &&
1798 read newline <&3 &&
1799
1800 cat <<EOF &&
@@ -1845,7 +1845,7 @@ test_expect_success PIPE 'R: print blob mid-commit' '
1845 EOF
1846
1847 read blob_id type size <&3 &&
1848 - dd if=/dev/stdin of=actual bs=$size count=1 <&3 &&
1848 + dd of=actual bs=$size count=1 <&3 &&
1849 read newline <&3 &&
1850
1851 echo
@@ -1880,7 +1880,7 @@ test_expect_success PIPE 'R: print staged blob within commit' '
1880 echo "cat-blob $to_get" &&
1881
1882 read blob_id type size <&3 &&
1883 - dd if=/dev/stdin of=actual bs=$size count=1 <&3 &&
1883 + dd of=actual bs=$size count=1 <&3 &&
1884 read newline <&3 &&
1885
1886 echo deleteall