@matheusbsbs / matheus-bagliano / commits / 49de47cfb2
Fork 0

t/t5505-remote.sh: escape * to prevent interpretation by shell as glob

This test is supposed to check that git-remote correctly refuses to delete all URLS for the specified remote which match the '.*' regular expression. Since the '*' was not protected, it was interpreted by the shell as a file glob and expanded before being passed to git-remote. The call to git-remote still exited non-zero in this case, and the overall test still passed, but it exited non-zero because git-remote was passed the incorrect number of arguments, not for the reason it was supposed to fail. Correct the test by escaping the '*'. Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Brandon Casey committed Mar 19, 2010 at 19:10 UTC 49de47cfb2d717b64cf93c5abeeefb87ee483de0
1 file changed +1 -1
t/t5505-remote.sh
+1 -1
@@ -662,7 +662,7 @@ test_expect_success 'remote set-url --add bbb' '
662 '
663
664 test_expect_success 'remote set-url --delete .*' '
665 - test_must_fail git remote set-url --delete someremote .* &&
665 + test_must_fail git remote set-url --delete someremote .\* &&
666 echo "YYY" >expect &&
667 echo baz >>expect &&
668 echo bbb >>expect &&