ci: check for common Rust mistakes via Clippy
Introduce a CI check that uses Clippy to perform checks for common mistakes and suggested code improvements. Clippy is the official static analyser of the Rust project and thus the de-facto standard. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Patrick Steinhardt committed
Oct 15, 2025 at 08:04 UTC
4b44c46432744a4975432eabba16ad60cb39e089
2 files changed
+6
-1
ci/install-dependencies.sh
+1
-1
index a24b07edff..dcd22ddd95 100755
--- a/ci/install-dependencies.sh
+++ b/ci/install-dependencies.sh
@@ -129,7 +129,7 @@ StaticAnalysis)
RustAnalysis)
sudo apt-get -q -y install rustup
rustup default stable
- rustup component add rustfmt
+ rustup component add clippy rustfmt
;;
sparse)
sudo apt-get -q -y install libssl-dev libcurl4-openssl-dev \
ci/run-rust-checks.sh
+5
index 082eb52f11..fb5ea8991b 100755
--- a/ci/run-rust-checks.sh
+++ b/ci/run-rust-checks.sh
@@ -9,4 +9,9 @@ then
RET=1
fi
+if ! group "Check for common Rust mistakes" cargo clippy --all-targets --all-features -- -Dwarnings
+then
+ RET=1
+fi
+
exit $RET