diff: drop complete_rewrite parameter from run_external_diff()
Our builtin_diff() wants to know whether break-detection found a complete rewrite, because it changes how the diff is shown. However, when calling out to an external diff, we don't pass this information along (and doing so would require designing a new interface to the user-provided program). Let's drop the unused parameter to make this fact more clear. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Feb 14, 2019 at 00:49 UTC
4bc1792750ede6b716c0c099c690bbf77ddea6bc
1 file changed
+1
-3
diff.c
+1
-3
@@ -4178,7 +4178,6 @@ static void run_external_diff(const char *pgm,
4178
struct diff_filespec *one,
4179
struct diff_filespec *two,
4180
const char *xfrm_msg,
4181
- int complete_rewrite,
4181
struct diff_options *o)
4182
{
4183
struct argv_array argv = ARGV_ARRAY_INIT;
@@ -4336,8 +4335,7 @@ static void run_diff_cmd(const char *pgm,
4335
}
4336
4337
if (pgm) {
4339
- run_external_diff(pgm, name, other, one, two, xfrm_msg,
4340
- complete_rewrite, o);
4338
+ run_external_diff(pgm, name, other, one, two, xfrm_msg, o);
4339
return;
4340
}
4341
if (one && two)