@matheusbsbs / matheus-bagliano / commits / 4d599e6bb4
Fork 0

bogus "fatal: Not a git repository"

I was just testing that "git ls-remote" change by Junio, and when you're not in a git repository, it gives this totally bogus warning. The _target_ obviously has to be a git repository, but there's no reason why you'd have to be in a local git repo when doing an ls-remote. The reason is commit 73136b2e8a8ee024320c5ac6a0f14f912432bf03 by Dscho: it adds calls to git-repo-config in git-parse-remote.sh to get the remote shorthands etc. Now, either we should just hide and ignore the error from git-repo-config (probably bad, because some errors _are_ valid - like git-repo-config failing due to bad syntax in the config file), or we should just make git-repo-config quietly handle the case of not being in a git repository. This does the latter: just quietly accepting (and doing nothing - trying to set a value will result in the lock-file failing) our lot in life sounds better than dying with a bogus error message. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Acked-By: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Junio C Hamano <junkio@cox.net>

Linus Torvalds committed May 25, 2006 at 08:22 UTC 4d599e6bb46d6ef3276425af34922fdbf3aac473
1 file changed +2 -1
repo-config.c
+2 -1
@@ -108,7 +108,8 @@ static int get_value(const char* key_, const char* regex_)
108
109 int main(int argc, const char **argv)
110 {
111 - setup_git_directory();
111 + int nongit = 0;
112 + setup_git_directory_gently(&nongit);
113
114 while (1 < argc) {
115 if (!strcmp(argv[1], "--int"))