@matheusbsbs / matheus-bagliano / commits / 4ecbc65fa7
Fork 0

Makefile: make ppc/sha1ppc.o depend on GIT-CFLAGS

The %.o: %.S pattern rule should depend on GIT-CFLAGS to avoid trouble when ALL_CFLAGS changes. The pattern only applies to one file (ppc/sha1ppc.S) and that file does not use any #ifdefs, so leaving the dependency out is probably harmless. Nevertheless, it is safer to include the dependency in case future code's behavior does depend on the build flags. Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jonathan Nieder committed Jan 6, 2010 at 00:37 UTC 4ecbc65fa7decb2aa271d68d54e8563a679e6ec1
1 file changed +1 -1
Makefile
+1 -1
@@ -1635,7 +1635,7 @@ git.o git.spec \
1635 $(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) $<
1636 %.s: %.c GIT-CFLAGS
1637 $(QUIET_CC)$(CC) -S $(ALL_CFLAGS) $<
1638 -%.o: %.S
1638 +%.o: %.S GIT-CFLAGS
1639 $(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) $<
1640
1641 exec_cmd.o: exec_cmd.c GIT-CFLAGS