promisor-remote: clarify that a remote is ignored
In should_accept_remote() and parse_one_advertised_remote(), when a remote is ignored, we tell users why it is ignored in a warning, but we don't tell them that the remote is actually ignored. Let's clarify that, so users have a better idea of what's actually happening. Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Christian Couder committed
Apr 7, 2026 at 13:52 UTC
4ed9283b36bc8652954578c3024a00b6e70f8960
1 file changed
+6
-5
promisor-remote.c
+6
-5
@@ -670,15 +670,16 @@ static int should_accept_remote(enum accept_promisor accept,
670
BUG("Unhandled 'enum accept_promisor' value '%d'", accept);
671
672
if (!remote_url || !*remote_url) {
673
- warning(_("no or empty URL advertised for remote '%s'"), remote_name);
673
+ warning(_("no or empty URL advertised for remote '%s', "
674
+ "ignoring this remote"), remote_name);
675
return 0;
676
}
677
678
if (!strcmp(p->url, remote_url))
679
return all_fields_match(advertised, config_info, p);
680
680
- warning(_("known remote named '%s' but with URL '%s' instead of '%s'"),
681
- remote_name, p->url, remote_url);
681
+ warning(_("known remote named '%s' but with URL '%s' instead of '%s', "
682
+ "ignoring this remote"), remote_name, p->url, remote_url);
683
684
return 0;
685
}
@@ -722,8 +723,8 @@ static struct promisor_info *parse_one_advertised_remote(const char *remote_info
723
string_list_clear(&elem_list, 0);
724
725
if (!info->name || !info->url) {
725
- warning(_("server advertised a promisor remote without a name or URL: %s"),
726
- remote_info);
726
+ warning(_("server advertised a promisor remote without a name or URL: '%s', "
727
+ "ignoring this remote"), remote_info);
728
promisor_info_free(info);
729
return NULL;
730
}