Clarify that http-push being temporarily disabled with older cURL
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Jan 21, 2008 at 17:34 UTC
4f5f998fbd64c997ea875d69fd86b6362e04ce9b
3 files changed
+23
-2
Documentation/RelNotes-1.5.4.txt
+12
-2
@@ -10,8 +10,18 @@ Removal
10
* As git-commit and git-status have been rewritten, "git runstatus"
11
helper script lost all its users and has been removed.
12
13
- * Curl library older than 7.10 is not supported by "git http-push",
14
- as it does not work without CURLM.
13
+
14
+Temporarily Disabled
15
+--------------------
16
+
17
+ * "git http-push" is known not to work well with cURL library older
18
+ than 7.16, and we had reports of repository corruption. It is
19
+ disabled on such platforms for now. Unfortunately, 1.5.3.8 shares
20
+ the same issue. In other words, this does not mean you will be
21
+ fine if you stick to an older git release. For now, please do not
22
+ use http-push from older git with cURL older than 7.16 if you
23
+ value your data. A proper fix will hopefully materialize in
24
+ later versions.
25
26
27
Deprecation notices
Documentation/git-http-push.txt
+3
@@ -15,6 +15,9 @@ DESCRIPTION
15
Sends missing objects to remote repository, and updates the
16
remote branch.
17
18
+*NOTE*: This command is temporarily disabled if your cURL
19
+library is older than 7.16, as the combination has been reported
20
+not to work and sometimes corrupts repository.
21
22
OPTIONS
23
-------
http.h
+8
@@ -8,6 +8,14 @@
8
9
#include "strbuf.h"
10
11
+/*
12
+ * We detect based on the cURL version if multi-transfer is
13
+ * usable in this implementation and define this symbol accordingly.
14
+ * This is not something Makefile should set nor users should pass
15
+ * via CFLAGS.
16
+ */
17
+#undef USE_CURL_MULTI
18
+
19
#if LIBCURL_VERSION_NUM >= 0x071000
20
#define USE_CURL_MULTI
21
#define DEFAULT_MAX_REQUESTS 5