t3600: comment on inducing SIGPIPE in `git rm`
Add a comment about intentionally inducing SIGPIPE since this is unusual and future developers should be aware. Also, even though we are trying to refactor git commands out of the upstream of pipes, we cannot do it here since we rely on it being upstream to induce SIGPIPE. Comment on that as well so that future developers do not try to change it. Signed-off-by: Denton Liu <liu.denton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Denton Liu committed
Nov 27, 2019 at 11:53 UTC
50cd31c6526637e59ca180397aba425ec7a1e218
1 file changed
+1
t/t3600-rm.sh
+1
@@ -251,6 +251,7 @@ test_expect_success 'choking "git rm" should not let it die with cruft' '
251
echo "100644 $hash 0 some-file-$i"
252
i=$(( $i + 1 ))
253
done | git update-index --index-info &&
254
+ # git command is intentionally placed upstream of pipe to induce SIGPIPE
255
git rm -n "some-file-*" | : &&
256
test_path_is_missing .git/index.lock
257
'