parse-options: drop unused ctx parameter from show_gitcomp()
The completion display doesn't actually care about where we are in the parsing. It's generated completely from the set of available options. So we don't need to see the parse-options context struct at all. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Mar 20, 2019 at 04:16 UTC
5205749d2ca81ea1d124ba7d799f4b319084ca68
1 file changed
+2
-3
parse-options.c
+2
-3
@@ -523,8 +523,7 @@ static void show_negated_gitcomp(const struct option *opts, int nr_noopts)
523
}
524
}
525
526
-static int show_gitcomp(struct parse_opt_ctx_t *ctx,
527
- const struct option *opts)
526
+static int show_gitcomp(const struct option *opts)
527
{
528
const struct option *original_opts = opts;
529
int nr_noopts = 0;
@@ -603,7 +602,7 @@ int parse_options_step(struct parse_opt_ctx_t *ctx,
602
603
/* lone --git-completion-helper is asked by git-completion.bash */
604
if (ctx->total == 1 && !strcmp(arg + 1, "-git-completion-helper"))
606
- return show_gitcomp(ctx, options);
605
+ return show_gitcomp(options);
606
607
if (arg[1] != '-') {
608
ctx->opt = arg + 1;