http: http.emptyauth should allow empty (not just NULL) usernames

When using Kerberos authentication with newer versions of libcurl, CURLOPT_USERPWD must be set to a value, even if it is an empty value. The value is never sent to the server. Previous versions of libcurl did not require this variable to be set. One way that some users express the empty username/password is http://:@gitserver.example.com, which http.emptyauth was designed to support. Another, equivalent, URL is http://@gitserver.example.com. The latter leads to a username of zero-length, rather than a NULL username, but CURLOPT_USERPWD still needs to be set (if http.emptyauth is set). Do so. Signed-off-by: David Turner <dturner@twosigma.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

David Turner committed Oct 4, 2016 at 10:53 UTC 5275c3081c2b2c6166a2fc6b253a3acb20f8ae89
1 file changed +1 -1
http.c
+1 -1
@@ -351,7 +351,7 @@ static int http_options(const char *var, const char *value, void *cb)
351
352 static void init_curl_http_auth(CURL *result)
353 {
354 - if (!http_auth.username) {
354 + if (!http_auth.username || !*http_auth.username) {
355 if (curl_empty_auth)
356 curl_easy_setopt(result, CURLOPT_USERPWD, ":");
357 return;