gitweb: correctly store previous rev in javascript-actions mode
Without this change, the setting $feature{'javascript-actions'}{'default'} = [1]; in gitweb.conf breaks gitweb's blame page: clicking on line numbers displayed in the second column on the page has no effect. For comparison, with javascript-actions disabled, clicking on line numbers loads the previous version of the line. Addresses https://bugs.debian.org/741883. Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Robert Luberda <robert@debian.org> Acked-by: Jakub Narębski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Robert Luberda committed
Oct 27, 2019 at 10:14 UTC
52bd3e46574baecf06562d4da857ba445981beb9
1 file changed
+1
-1
gitweb/static/js/blame_incremental.js
+1
-1
@@ -484,7 +484,7 @@ function processBlameLines(lines) {
484
case 'previous':
485
curCommit.nprevious++;
486
// store only first 'previous' header
487
- if (!'previous' in curCommit) {
487
+ if (!('previous' in curCommit)) {
488
var parts = data.split(' ', 2);
489
curCommit.previous = parts[0];
490
curCommit.file_parent = unquote(parts[1]);