mv: be quiet about overwriting
When a user asks us to force a mv and overwrite the destination, we print a warning. However, since a typical use would be: $ git mv one two fatal: destination exists, source=one, destination=two $ git mv -f one two warning: overwriting 'two' this warning is just noise. We already know we're overwriting; that's why we gave -f! This patch silences the warning unless "--verbose" is given. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Dec 12, 2011 at 16:54 UTC
534376ca04d524b99d69a30bdcf5e70ac8062aee
1 file changed
+2
-1
builtin/mv.c
+2
-1
@@ -173,7 +173,8 @@ int cmd_mv(int argc, const char **argv, const char *prefix)
173
* check both source and destination
174
*/
175
if (S_ISREG(st.st_mode) || S_ISLNK(st.st_mode)) {
176
- warning(_("overwriting '%s'"), dst);
176
+ if (verbose)
177
+ warning(_("overwriting '%s'"), dst);
178
bad = NULL;
179
} else
180
bad = _("Cannot overwrite");