@matheusbsbs / matheus-bagliano / commits / 535514f1f3
Fork 0

New files in git weren't being downloaded during CVS update

If a repository was checked out via git-cvsserver and then later a new file is added to the git repository via some other method; a CVS update wasn't fetching the new file. It would be reported as a new file as A some/dir/newfile.c but would never appear in the directory. The problem seems to be that git-cvsserver was treating these two cases identically, as "A" type results. 1. New file in repository 2. New file locally In fact, traditionally, case 1 is treated as a "U" result, and case 2 only is treated as an "A" result. "A", should just report that the file is added locally and then skip that file during an update as there is (of course) nothing to send. In both these cases there is no working revision, so the checking for "is there no working revision" will return true. The test for case 2 needs refining to say "if there is no working revision and no upstream revision". This patch does just that, leaving case 1 to be handled by the normal "U" handler. I've also updated the log message to more accurately describe the operation. i.e. that "A" means that content is scheduled for addition; not that it actually has been added. Signed-off-by: Andy Parkins <andyparkins@gmail.com> Signed-off-by: Junio C Hamano <junkio@cox.net>

Andy Parkins committed Jan 22, 2007 at 10:56 UTC 535514f1f3cd32dfe2cb4c70e97b41ea868d1134
1 file changed +3 -3
git-cvsserver.perl
+3 -3
@@ -876,9 +876,9 @@ sub req_update
876 print "MT newline\n";
877 next;
878 }
879 - elsif ( !defined($wrev) || $wrev == 0 )
879 + elsif ( (!defined($wrev) || $wrev == 0) && (!defined($meta->{revision}) || $meta->{revision} == 0) )
880 {
881 - $log->info("Tell the client the file will be added");
881 + $log->info("Tell the client the file is scheduled for addition");
882 print "MT text A \n";
883 print "MT fname $filename\n";
884 print "MT newline\n";
@@ -886,7 +886,7 @@ sub req_update
886
887 }
888 else {
889 - $log->info("Updating '$filename' $wrev");
889 + $log->info("Updating '$filename' to ".$meta->{revision});
890 print "MT +updated\n";
891 print "MT text U \n";
892 print "MT fname $filename\n";