xdiff: cleanup xdl_clean_mmatch()
Remove the "s" parameter as, since the last commit, this function is always called with s == 0. Also change parameter "e" to expect a length, rather than the index of the last line to simplify the caller. Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Phillip Wood committed
May 4, 2026 at 15:06 UTC
53d13887b8581d46dffc1f4ee2622c977b65ecb5
1 file changed
+4
-3
xdiff/xprepare.c
+4
-3
@@ -197,8 +197,9 @@ void xdl_free_env(xdfenv_t *xe) {
197
}
198
199
200
-static bool xdl_clean_mmatch(uint8_t const *action, ptrdiff_t i, ptrdiff_t s, ptrdiff_t e) {
200
+static bool xdl_clean_mmatch(uint8_t const *action, ptrdiff_t i, ptrdiff_t len) {
201
ptrdiff_t r, rdis0, rpdis0, rdis1, rpdis1;
202
+ ptrdiff_t s = 0, e = len - 1;
203
204
/*
205
* Limits the window that is examined during the similar-lines
@@ -342,7 +343,7 @@ static int xdl_cleanup_records(xdlclassifier_t *cf, xdfile_t *xdf1, xdfile_t *xd
343
uint8_t action = action1[i];
344
345
if (action == INVESTIGATE) {
345
- if (!xdl_clean_mmatch(action1, i, 0, len1 - 1))
346
+ if (!xdl_clean_mmatch(action1, i, len1))
347
action = KEEP;
348
else
349
action = DISCARD;
@@ -363,7 +364,7 @@ static int xdl_cleanup_records(xdlclassifier_t *cf, xdfile_t *xdf1, xdfile_t *xd
364
uint8_t action = action2[i];
365
366
if (action == INVESTIGATE) {
366
- if (!xdl_clean_mmatch(action2, i, 0, len2 - 1))
367
+ if (!xdl_clean_mmatch(action2, i, len2))
368
action = KEEP;
369
else
370
action = DISCARD;